Fix bluetooth shell issue #90065
Fix bluetooth shell issue #90065
Conversation
This string contains two consecutive spaces. Remove one of them. Signed-off-by: Can Wang <[email protected]>
Host stack supports to set BR security level to 4 but the security level cannot be set to 4 by the shell command. Update the code to support BR security level 4. Signed-off-by: Can Wang <[email protected]>
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
github-actions
bot
requested review from
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
LE and BR connection have already been established, after that, LE disconnection occurs, BR connection will not be selected as the next default connection. Fix this issue by searching for both BR and LE after disconnection occurs. Signed-off-by: Can Wang <[email protected]>
CanWang001
force-pushed
the
fix_bt_shell_issue
branch
from
5b26acd to
ab43e18
Compare
|
|
Is there anyone else who can help review this? Thanks |
| bt_conn_unref(default_conn); | ||
| default_conn = NULL; | ||
|
|
||
| /* If we are connected to other devices, set one of them as default */ | ||
| bt_conn_foreach(BT_CONN_TYPE_LE, disconnected_set_new_default_conn_cb, NULL); | ||
| bt_conn_foreach(info.type, disconnected_set_new_default_conn_cb, NULL); |
There was a problem hiding this comment.
Wouldn't it be more accurate like this?:
| bt_conn_foreach(info.type, disconnected_set_new_default_conn_cb, NULL); | |
| bt_conn_foreach(BT_CONN_TYPE_LE | BT_CONN_TYPE_BR, disconnected_set_new_default_conn_cb, NULL); |
I believe it's more accurate because we don't really care about what the type of the disconnected connection is for the purpose of selecting a different connection.
I don't know what the difference between BT_CONN_TYPE_BR and BT_CONN_TYPE_SCO is, so it may be SCO is correct instead.
There was a problem hiding this comment.
Hi alwa-nordic, as the comments from Thalley, he expects to set a new default conn with the same type first.
Consider a requirement: If there are 4 connections: 2 LE and 2 BR/EDR, and the disconnected one is a BR/EDR, and we want to select the other BR/EDR connection.
SCO disconnection will not reach this callback and will use its own callback.
There was a problem hiding this comment.
OK. I'll defer to @Thalley's decision.
There was a problem hiding this comment.
Alternatively we could remove the "select next" feature.
The reasoning is that if I was doing some GATT operations on an LE default_conn, and then it disconnects, then I'd assume I could either continue with GATT operations, or not do any operations.
Perhaps the "select next" feature isn't that useful for multiple different types of connections?
There was a problem hiding this comment.
If this PR #90123 is merged, and we use bt select and br select shell command to select different types of connections. After that, the "select next" may be removed.
Anyway, the "select next" provide the possibility to be unnecessary to enter bt select or br select.
|
Hi @CanWang001! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
This PR contains three patches: